Wireshark-commits: [Wireshark-commits] master-2.0 5438809: Fix compile problems on OS X.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 30 Dec 2015 01:18:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=543880955f03bf7eabf4cc58bea6202b41cea427
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

5438809 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix compile problems on OS X.
    
    Apparently, the C++ compilers on the OS X buildbots don't realize that a
    reference cannot be null and therefore that there's nothing ambiguous
    about QString(NULL) - the NULL must be a "const char *".  Instead, use a
    constructed null QString.
    
    Change-Id: Ibc56ea7f84c5e49cf3b1974c3de905bf23e90ff0
    Reviewed-on: https://code.wireshark.org/review/12928
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 36615661d5b0bacef519a64a3cc24cf9d4270117)
    Reviewed-on: https://code.wireshark.org/review/12938
    

Actions performed:

    from  a5d4dbd   Revert "Revert "Qt: Add support of gui.window_title""
    adds  5438809   Fix compile problems on OS X.


Summary of changes:
 ui/qt/main_window.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)