Wireshark-commits: [Wireshark-commits] master ddd2174: Always supply a g_mallocated error message f
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 29 Dec 2015 08:02:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ddd217469de7032a3509369b3ca7dfca55374c2e
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ddd2174 by Guy Harris (guy@xxxxxxxxxxxx):

    Always supply a g_mallocated error message from select_rlc_lte_session().
    
    That way, we don't have to pass a "free this" indication separately.
    
    While we're at it, don't just free the error message, *display* it in
    all cases where rlc_graph_segment_list_get() fails.
    
    (I wish more programming languages had a proper string type, including
    some whose names consist solely of the third letter of the alphabet, but
    I digress....)
    
    Change-Id: I99f8b088aa19bc8fbb178bdb36d85ba5b89c06e0
    Reviewed-on: https://code.wireshark.org/review/12902
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  98456ce   debian: Recommend libqt5multimedia5-plugins for wireshark-qt
    adds  ddd2174   Always supply a g_mallocated error message from select_rlc_lte_session().


Summary of changes:
 ui/gtk/rlc_lte_graph.c         |   20 ++++++++++++--------
 ui/qt/lte_rlc_graph_dialog.cpp |    7 ++-----
 ui/tap-rlc-graph.c             |   16 ++++++----------
 ui/tap-rlc-graph.h             |    4 ++--
 4 files changed, 22 insertions(+), 25 deletions(-)