Wireshark-commits: [Wireshark-commits] master f8452b0: ZigBee: fix for inabulity to parse ZigBee pa
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 27 Dec 2015 15:20:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f8452b018092d8aea247cd51d72e3fe75ef31504
Submitter: Graham Bloice (graham.bloice@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f8452b0 by dsrsupport (eugene.exarevsky@xxxxxxxxxxxxxxx):

    ZigBee: fix for inabulity to parse ZigBee packets due to parsing _any_ IEEE 802.15.4 packet as a command.
    
    In dissect_ieee802154_common() any packet unconditionally parsed as a command, command it byte cut.
    As a result, all except MAC commands are garbaged.
    Added check for the frame type and parce/cut command id only for 802.15.4 commands.
    
    Bug: 11929
    Change-Id: Iab17d28c19485063e3d802eec3dc03a9d9c33a7a
    Reviewed-on: https://code.wireshark.org/review/12860
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
    

Actions performed:

    from  d48b0ef   Sanity check column size to prevent allocating an unrealistic amount of memory.
    adds  f8452b0   ZigBee: fix for inabulity to parse ZigBee packets due to parsing _any_ IEEE 802.15.4 packet as a command.


Summary of changes:
 epan/dissectors/packet-ieee802154.c |   27 ++++++++++++++-------------
 1 file changed, 14 insertions(+), 13 deletions(-)