Wireshark-commits: [Wireshark-commits] master 35ee09e: capture_info: Fix initialization of packet c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 23 Dec 2015 11:35:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=35ee09e0f0dfccc0db23a7b34548943ef54a6a74
Submitter: Stig Bj?rlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

35ee09e by Roland Knall (roland.knall@xxxxxxxxxxxxxxxxx):

    capture_info: Fix initialization of packet counter
    
     g_hash_table_destroy will crash, if it is called on
     non-initialized memory. For some reason, this does not happen
     with other glib lists (e.g. GList seems to guard cleanly).
    
     This change initializes at the earliest possible time the
     packet counter hash with NULL
    
    Change-Id: Ice66652fc9639d10b49d006ecbe80efe3f41e2ff
    Reviewed-on: https://code.wireshark.org/review/12841
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  0285fb9   Adding MULTISTATE OUTPUT (BASIC) CLUSTER,MULTISTATE INPUT (BASIC) CLUSTER,MULTISTATE VALUE (BASIC) CLUSTER
    adds  35ee09e   capture_info: Fix initialization of packet counter


Summary of changes:
 tshark.c              |    3 +++
 ui/gtk/main.c         |    3 +++
 ui/qt/main_window.cpp |    3 +++
 3 files changed, 9 insertions(+)