Wireshark-commits: [Wireshark-commits] master-2.0 0bfb175: ui: Plug memory leak in decode_build_res
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 23 Dec 2015 08:46:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0bfb175c2de5422345b4b1bef74395b9f3600708
Submitter: Stig Bj?rlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

0bfb175 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    ui: Plug memory leak in decode_build_reset_list.
    
    The strings passed to decode_build_reset_list() is not freed, so
    ensure we cleanup in decode_clear_all().
    
    Change-Id: Ib68bde71403e260199482831272beb161fe033f9
    Reviewed-on: https://code.wireshark.org/review/12836
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    (cherry picked from commit 976642ab0a6099010d08113fe4080010d39ab766)
    Reviewed-on: https://code.wireshark.org/review/12838
    

Actions performed:

    from  ada125e   ui: Optimize col_custom_prime_edt()
    adds  0bfb175   ui: Plug memory leak in decode_build_reset_list.


Summary of changes:
 epan/packet.h          |    2 +-
 ui/decode_as_utils.c   |   11 ++++++-----
 ui/gtk/decode_as_dlg.c |    2 +-
 3 files changed, 8 insertions(+), 7 deletions(-)