Wireshark-commits: [Wireshark-commits] master-1.12 3065829: airpdcap: add free_key_string function,
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 21 Dec 2015 12:42:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=30658294265790af21896b93267384d5a8229bad
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

3065829 by Peter Wu (peter@xxxxxxxxxxxxx):

    airpdcap: add free_key_string function, fix memleaks
    
    Do not leak the key and SSID. Note that there are still some leaks in
    the GTK UI related to get_wireshark_keys(), but I did not track them
    down.
    
    Caught by LeakSanitizer.
    
    Change-Id: I91308a9cd5d91d601bc778bdf10bfae8254ad2af
    Reviewed-on: https://code.wireshark.org/review/12792
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  bb3c2e5   Move some stuff into the only code path where it's used.
    adds  3065829   airpdcap: add free_key_string function, fix memleaks


Summary of changes:
 debian/libwireshark5.symbols       |    1 +
 epan/crypt/airpdcap.c              |   10 ++++++++++
 epan/crypt/airpdcap_user.h         |   11 ++++++++++-
 epan/dissectors/packet-ieee80211.c |    1 +
 4 files changed, 22 insertions(+), 1 deletion(-)