Wireshark-commits: [Wireshark-commits] master 5f2f6a3: [airpdcap rijndael] use packet scoped wmem m
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 21 Dec 2015 05:25:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5f2f6a395a267112396c2965432fa40cf28dee3c
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5f2f6a3 by Martin Kaiser (wireshark@xxxxxxxxx):

    [airpdcap rijndael] use packet scoped wmem memory in AES_unwrap()
    
    at the moment, AirPDcapDecryptWPABroadcastKey() does not free the buffer
    allocated by AES_unwrap() if there's an error while parsing the returned data
    
    this could be fixed by adding more g_free() calls or by using wmem
    memory
    
    Change-Id: I332968da2186fbd17cbb7708082fa701dcab668e
    Reviewed-on: https://code.wireshark.org/review/12744
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  83f2818   [airpdcap] check the length of the WPA broadcast key we calculated
    adds  5f2f6a3   [airpdcap rijndael] use packet scoped wmem memory in AES_unwrap()


Summary of changes:
 epan/crypt/airpdcap.c          |    2 --
 epan/crypt/airpdcap_rijndael.c |    6 ++----
 2 files changed, 2 insertions(+), 6 deletions(-)