Wireshark · Wireshark-commits: [Wireshark-commits] master-2.0 dcba250: Add bounds checks and fix a length argument.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dcba2505150748c43d4a6551f32d178ec65e1512
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

dcba250 by Guy Harris (guy@xxxxxxxxxxxx):

    Add bounds checks and fix a length argument.
    
    Before reading the record header of a REC_FRAME{2,4,6} record, make sure
    the record length is >= the length of that header.
    
    Whe calling fix_pseudo_header(), pass the actual length of the packet
    data, not the remaining length of the record (which may include
    padding), so we don't read past the end of the packet data.
    
    Bug: 11827
    Change-Id: I1c63a4cb014c4616ffdd202660e68c576f266872
    Reviewed-on: https://code.wireshark.org/review/12756
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 53a3e53fce30523d11ab3df319fba7b75d63076f)
    Reviewed-on: https://code.wireshark.org/review/12757
    

Actions performed:

    from  7008907   Qt: Fix Confirm unsaved capture files preference.
    adds  dcba250   Add bounds checks and fix a length argument.


Summary of changes:
 wiretap/ngsniffer.c |   49 ++++++++++++++++++++++++++++++++++---------------
 1 file changed, 34 insertions(+), 15 deletions(-)