Wireshark-commits: [Wireshark-commits] master 49d612d: [AES_unwrap] initialize the output array wit
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 20 Dec 2015 15:24:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=49d612df06d9d07ae170e98283ccb76c3bb6bfb2
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

49d612d by Martin Kaiser (wireshark@xxxxxxxxx):

    [AES_unwrap] initialize the output array with 0s
    
    for cipher_len==56, some bytes of the output array are not written
    
    An alternative approach would be to add a check for cipher_len.
    I understand from RFC 3394 that the AES key wrap algorithm works on
    multiples of 64bits and has no upper limit, we couldn't easily reject 56
    bytes cipher_len.
    
    Bug: 11527
    Change-Id: Ie82357bbe5512de391813dd55098df7a16bda9ae
    Reviewed-on: https://code.wireshark.org/review/12741
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  df10186   [USB] dissect the data part in outgoing isochronous URBs on Linux
    adds  49d612d   [AES_unwrap] initialize the output array with 0s


Summary of changes:
 epan/crypt/airpdcap_rijndael.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)