Wireshark-commits: [Wireshark-commits] master 7046b4b: extcap: plug some memleaks
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 19 Dec 2015 23:24:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7046b4b0840e106a1361f4fda8497eaeafe652dc
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7046b4b by Peter Wu (peter@xxxxxxxxxxxxx):

    extcap: plug some memleaks
    
    The working directory for g_spawn_sync should not be escaped, it is
    simply passed to chdir. The escaping was needed for the command, so do
    so (hmm... maybe the argv arguments should be escaped too for Windows).
    
    Also remove an unnecessary NULL command argument for extcap_foreach.
    
    Note: there is still a memleak when exiting because the ifaces table is
    not cleared after querying the list.
    
    Change-Id: I1251d623b954a81848044b6d1faf8dcec8ce465b
    Reviewed-on: https://code.wireshark.org/review/12530
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  07f0cf8   Add menu item for capture comment dialog in GTK+
    adds  7046b4b   extcap: plug some memleaks


Summary of changes:
 extcap.c        |   55 +++++++++++++++++++++++++++++++++----------------------
 extcap_parser.c |   18 ++++++++++++------
 2 files changed, 45 insertions(+), 28 deletions(-)