Wireshark-commits: [Wireshark-commits] master 68ca26e: Don't report an error for a non-multiple-of-
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=68ca26ec75fb9cccbb64a859cafa1fb2c3d0cce7
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
68ca26e by Guy Harris (guy@xxxxxxxxxxxx):
Don't report an error for a non-multiple-of-4 chunk length.
To quote RFC 4960:
Chunk Length: 16 bits (unsigned integer)
This value represents the size of the chunk in bytes, including
the Chunk Type, Chunk Flags, Chunk Length, and Chunk Value fields.
Therefore, if the Chunk Value field is zero-length, the Length
field will be set to 4. *The Chunk Length field does not count any
chunk padding.*
Chunks (including Type, Length, and Value fields) are padded out
by the sender with all zero bytes to be a multiple of 4 bytes
long. This padding MUST NOT be more than 3 bytes in total. The
Chunk Length value does not include terminating padding of the
chunk. However, it does include padding of any variable-length
parameter except the last parameter in the chunk. The receiver
MUST ignore the padding.
Note: A robust implementation should accept the chunk whether or
not the final padding has been included in the Chunk Length.
so the the chunk is *not* required to include the length of the final
padding in the chunk, although any padding *between* variable-length
parameters in the chunk must be included in the length (obviously, as
it's part of the chunk data).
Change-Id: I99d64fdd907c41229aa9ad10a230fff4bcdfa5f4
Reviewed-on: https://code.wireshark.org/review/12664
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from 396c92a [GTPv2] Add dissection of Source to Target Transparent Container in SRVCC PS to CS Request
adds 68ca26e Don't report an error for a non-multiple-of-4 chunk length.
Summary of changes:
epan/dissectors/packet-sctp.c | 2 --
1 file changed, 2 deletions(-)
