Wireshark-commits: [Wireshark-commits] master 9132706: T.38: don't register for TCP and UDP ports 6
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 15 Dec 2015 04:38:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9132706b2dca67c4991edf0f3779d1d43d4b3f65
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9132706 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    T.38: don't register for TCP and UDP ports 6004.
    
    T.38 normally picks up its port number dynamically from signalling, port 6004
    isn't registered to T.38, and anyway port 6004 is now (correctly) registered
    to X11.
    
    (For the cases where the signaling is missing there's still Decode-As.)
    
    Change-Id: I53d8aa27ed1b042dd60bbdb0df2bd89254f1f001
    Reviewed-on: https://code.wireshark.org/review/12640
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  fbf2e3c   Make init_progfile_dir() take a function pointer [-Wpedantic]
    adds  9132706   T.38: don't register for TCP and UDP ports 6004.


Summary of changes:
 asn1/t38/packet-t38-template.c |   66 ++++++++++++----------------------
 epan/dissectors/packet-t38.c   |   76 ++++++++++++++--------------------------
 2 files changed, 49 insertions(+), 93 deletions(-)