Wireshark-commits: [Wireshark-commits] master d835b27: Create some more capture dissector tables.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 14 Dec 2015 22:35:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d835b271679c5e5eae7146b96ae1a65cbd5c16b4
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d835b27 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Create some more capture dissector tables.
    
    These were created from capture dissector functions that had switch statements determine "next" protocol/dissector.  The registration decreases the need for function declarations in header files.
    
    Added new capture dissection tables for IP, IPv6, TCP and UDP as that seems like the next logical place to expand
    
    Change-Id: I1ec0cd54eecda4f400669ee5b026bf6e2b46545a
    Reviewed-on: https://code.wireshark.org/review/12634
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  54413c8   Note why we do -Wno-variadic-macros.
    adds  d835b27   Create some more capture dissector tables.


Summary of changes:
 epan/dissectors/Makefile.common    |    1 -
 epan/dissectors/packet-arcnet.c    |    3 +-
 epan/dissectors/packet-arp.c       |    1 +
 epan/dissectors/packet-arp.h       |    1 +
 epan/dissectors/packet-atm.c       |   31 ++++------------
 epan/dissectors/packet-ax25.c      |   14 ++------
 epan/dissectors/packet-clip.c      |    8 +----
 epan/dissectors/packet-enc.c       |   69 ++++++++++--------------------------
 epan/dissectors/packet-eth.c       |    4 +++
 epan/dissectors/packet-gre.c       |   10 ++++++
 epan/dissectors/packet-icmp.c      |   10 ++++++
 epan/dissectors/packet-icmpv6.c    |    9 +++++
 epan/dissectors/packet-ieee80211.c |    1 +
 epan/dissectors/packet-ip.c        |   36 ++++---------------
 epan/dissectors/packet-ipv6.c      |   32 +++--------------
 epan/dissectors/packet-ipx.c       |    2 ++
 epan/dissectors/packet-llc.c       |    2 ++
 epan/dissectors/packet-netrom.c    |    6 ++--
 epan/dissectors/packet-netrom.h    |   30 ----------------
 epan/dissectors/packet-ospf.c      |   11 ++++++
 epan/dissectors/packet-ppi.c       |   13 ++-----
 epan/dissectors/packet-ppp.c       |   14 +++-----
 epan/dissectors/packet-sctp.c      |   10 ++++++
 epan/dissectors/packet-sll.c       |   29 ++-------------
 epan/dissectors/packet-tcp.c       |   40 +++++++++++++++++++++
 epan/dissectors/packet-tr.c        |    2 ++
 epan/dissectors/packet-udp.c       |   43 ++++++++++++++++++++++
 epan/dissectors/packet-vines.c     |    3 ++
 28 files changed, 199 insertions(+), 236 deletions(-)
 delete mode 100644 epan/dissectors/packet-netrom.h