Wireshark-commits: [Wireshark-commits] master-2.0 cfe5da7: Ping on Windows isn't necessarily IPv4-o
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 12 Dec 2015 22:07:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cfe5da74e7ded43da11b1bf4465ab0f56f6fcbf1
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

cfe5da7 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Ping on Windows isn't necessarily IPv4-only.
    
    The default prefix policy on modern versions of Windows prefers IPv6.
    This in combination with the fact that our ping target (www.wireshark.org)
    currently has both A and AAAA records might result in ICMPv6 traffic
    instead of ICMPv4. Update the capture test suite accordingly.
    
    Change-Id: I5c88f24fb9458526ffd44c5003f09247b6999ce7
    Reviewed-on: https://code.wireshark.org/review/12553
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 4454fb02c7d37803d99c9a1228db35b2c8f75220)
    Reviewed-on: https://code.wireshark.org/review/12577
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  07dbf78   Increase ZBEE_ZCL_APPL_EVTALT_NUM_STRUCT_ETT to match ZBEE_ZCL_APPL_EVTALT_COUNT_NUM_MASK, to prevent invalid ett_ array access.
    adds  cfe5da7   Ping on Windows isn't necessarily IPv4-only.


Summary of changes:
 test/suite-capture.sh |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)