Wireshark-commits: [Wireshark-commits] master-2.0 8a32bd5: ssl: fix SSLv2 Client Hello dissection
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 11 Dec 2015 05:24:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8a32bd5c921b4f0030ac3dce03e548c4e33ffbfe
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

8a32bd5 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl: fix SSLv2 Client Hello dissection
    
    Regression introduced with v1.99.4rc0-112-gf0855e0 ("Remove
    proto_tree_add_text from packet-ssl.c").
    
    While SSL decryption is not needed on the second pass, the items still
    have to be added.
    
    Bug: 11851
    Change-Id: Iccb43f2ccff19bbe6d998fb08600b226ac054825
    Reviewed-on: https://code.wireshark.org/review/12510
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit c96b78f28d72fb2ad05a6370ffb6708be55a5030)
    Reviewed-on: https://code.wireshark.org/review/12522
    

Actions performed:

    from  60ddbdd   Qt: restore conversation coloring rule shortcuts
    adds  8a32bd5   ssl: fix SSLv2 Client Hello dissection


Summary of changes:
 epan/dissectors/packet-ssl.c |  171 +++++++++++++++++++++---------------------
 1 file changed, 84 insertions(+), 87 deletions(-)