Wireshark-commits: [Wireshark-commits] master 9c47cb4: Fix Recurring check found by PVS Studio (V57
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 11 Dec 2015 05:14:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9c47cb4254e6aa188cd15c1aebe660a6356d91ca
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9c47cb4 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    Fix Recurring check found by PVS Studio (V571)
    
    packet-ncp2222.inc: The 'ncp_rec->func == 0x59' condition was already verified in line 7300.
    packet-bgp: The 'nlri_len < 21' condition was already verified in line 3879
    packet-rtp.c: The 'p_conv_data' condition was already verified in line 1460
    
    Change-Id: I65299718b26454596e3f25665d413a17a99e4ce0
    Reviewed-on: https://code.wireshark.org/review/12341
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  9902878   Completely remove new_create_dissector_handle and new_register_dissector.
    adds  9c47cb4   Fix Recurring check found by PVS Studio (V571)


Summary of changes:
 epan/dissectors/packet-bgp.c       |    8 +++-----
 epan/dissectors/packet-ncp2222.inc |    2 +-
 epan/dissectors/packet-rtp.c       |    2 +-
 3 files changed, 5 insertions(+), 7 deletions(-)