Wireshark-commits: [Wireshark-commits] master 1a1893a: androiddump: fix crash on Windows when runni
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 8 Dec 2015 16:33:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1a1893ad54a402bda3b77262ecaf68cfe9831368
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1a1893a by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    androiddump: fix crash on Windows when running in verbose mode
    
    As explained in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6695#c2
    g_frpintf unfortunately crashed on Windows. Let's go back to fprintf instead.
    It will create warnings with MSVC2015 but we do not use it officially yet and
    at least androiddump will be working correctly again.
    
    Change-Id: Idfdb608576e18af63650af80e01bcda36dd81ac4
    Reviewed-on: https://code.wireshark.org/review/12435
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  2f2c878   Fix crash caused by nullptr in packet_list
    adds  1a1893a   androiddump: fix crash on Windows when running in verbose mode


Summary of changes:
 extcap/androiddump.c |  266 +++++++++++++++++++++++++-------------------------
 1 file changed, 133 insertions(+), 133 deletions(-)