Wireshark-commits: [Wireshark-commits] master 62b64e3: opcua: expand ReturnDiagnostics field of Req
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 8 Dec 2015 02:18:12 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=62b64e394242597883e32baeb268ef6746a431c6
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

62b64e3 by Hannes Mezger (hannes.mezger@xxxxxxxxxxx):

    opcua: expand ReturnDiagnostics field of RequestHeader
    
    The ReturnDiagnostics field of RequestHeader is a bitmask. It cannot be generated, as the information needed is not contained in our models used to generate the generated files. This is why I made a manual change to opcua_complextypeparser.c. In the future, this change has to be merged if the file gets regenerated.
    
    Change-Id: Ic7db499566e3f3d3006feaff6e25e7b37a427dca
    Reviewed-on: https://code.wireshark.org/review/12470
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  3a4d387   opcua: fix order of ExpandedNodeId bits
    adds  62b64e3   opcua: expand ReturnDiagnostics field of RequestHeader


Summary of changes:
 plugins/opcua/opcua_complextypeparser.c |   15 ++-
 plugins/opcua/opcua_simpletypes.c       |  152 +++++++++++++++++++------------
 plugins/opcua/opcua_simpletypes.h       |   14 +++
 3 files changed, 121 insertions(+), 60 deletions(-)