Wireshark-commits: [Wireshark-commits] master d382c7d: SCTP: It is odd that the body of dissect_hea
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 6 Dec 2015 03:00:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d382c7d321642dae8f25e4257da644d87b645c65
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d382c7d by Michael Tüxen (tuexen@xxxxxxxxxxxxx):

    SCTP: It is odd that the body of dissect_heartbeat_ack_chunk' function is fully equivalent to the body of 'dissect_heartbeat_chunk' function found by PVS Studio (V524)
    
    This is just a cosmetic change, which makes sense. No funtional
    change.
    
    Change-Id: Id24d162379093207863608e70f405e66f789276c
    Reviewed-on: https://code.wireshark.org/review/12440
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Tüxen
    Reviewed-by: Michael Tüxen <tuexen@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    

Actions performed:

    from  4348d4d   Type cleanups.
    adds  d382c7d   SCTP: It is odd that the body of dissect_heartbeat_ack_chunk' function is fully equivalent to the body of 'dissect_heartbeat_chunk' function found by PVS Studio (V524)


Summary of changes:
 epan/dissectors/packet-sctp.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)