Wireshark-commits: [Wireshark-commits] master 70cf540: RTPS: Minor improvements
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 5 Dec 2015 12:17:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=70cf540ac60c1ac07c2e985e0b8bea6d6315611b
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

70cf540 by Juanjo Martin (juanjo@xxxxxxx):

    RTPS: Minor improvements
    
    1) Fixed the guidPrefix deserialization (before it was showing
    counter and it should be instanceId).
    2) The PID_PARTICIPANT_GUID was a total mess. Now it looks perfect.
    3) Fixed some bounds in the proto_tree creations so instead of
    selecting the rest of the tvb, now they select what they have to.
    
    Did all of this keeping the dissection for version 1 untouched.
    
    Change-Id: I93df2a29e292655ceb3f8c1395f31d8e38106dee
    Reviewed-on: https://code.wireshark.org/review/12406
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  b56f538   Build Flex-generated files with "warnings are errors".
    adds  70cf540   RTPS: Minor improvements


Summary of changes:
 epan/dissectors/packet-rtps.c |  102 +++++++++++++++++++++--------------------
 1 file changed, 53 insertions(+), 49 deletions(-)