Wireshark · Wireshark-commits: [Wireshark-commits] master 7474748: qt: Refresh local interface list only when interfaces added/remo

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=74747489ac9b67a06a4f53e14de66c0842165136
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7474748 by Mikael Kanstrup (mikael.kanstrup@xxxxxxxxx):

    qt: Refresh local interface list only when interfaces added/removed
    
    Whenever data is received on the iface monitor socket the list of
    local network interfaces is refreshed. No check whether an interface
    is really added/removed is done. Changes to network interface options
    like promiscous mode flag generate traffic on the iface monitor socket
    that not necessarily mean an interface was brought up or down resulting
    in an unwanted refresh of local interfaces.
    
    When local interfaces are refreshed selected capture interface(s) get
    deselected. This in turn makes "Restart current capture" fail with a no
    capture interface selected error.
    
    Fixed by moving the refresh action from socket monitor callback to iface
    monitor callback where interface up/down status is known.
    
    Bug: 11834
    Change-Id: Iffd39c3240049880b5a8311bc6484f3d1433f387
    Reviewed-on: https://code.wireshark.org/review/12317
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  d7ddebb   Qt: Update menus with new recent settings when changing profile
    adds  7474748   qt: Refresh local interface list only when interfaces added/removed


Summary of changes:
 ui/qt/wireshark_application.cpp |   10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)