Wireshark-commits: [Wireshark-commits] master-2.0 4af0b80: Qt: Check display filter when changing p
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 3 Dec 2015 04:55:57 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4af0b809d18d097857d9f6ac5c7a382892c30090
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

4af0b80 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Check display filter when changing profile
    
    The Display Filter Macros may have changed and if a macro is currently
    used in the display filter then cf_redissect_packets() will bail
    out in an assert if trying to apply an invalid filter.
    
    Change-Id: I842016360672d76d190454ce80ccc7604f2075b3
    Reviewed-on: https://code.wireshark.org/review/12388
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 6b7da34b4b8b6f5e6a0c7ee3bf4d2f3ec2af4333)
    Reviewed-on: https://code.wireshark.org/review/12395
    

Actions performed:

    from  51a80e2   Qt: fix selection of folder in UAT dialog
    adds  4af0b80   Qt: Check display filter when changing profile


Summary of changes:
 ui/qt/main_window.cpp           |    2 ++
 ui/qt/main_window.h             |    1 +
 ui/qt/main_window_slots.cpp     |   13 +++++++++----
 ui/qt/wireshark_application.cpp |    2 +-
 ui/qt/wireshark_application.h   |    1 +
 5 files changed, 14 insertions(+), 5 deletions(-)