Wireshark-commits: [Wireshark-commits] master-2.0 51a80e2: Qt: fix selection of folder in UAT dialo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 3 Dec 2015 04:52:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=51a80e2d5a7b92e58b24812fb5fc9bf9c01d6436
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

51a80e2 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Qt: fix selection of folder in UAT dialog
    
    Using getOpenFileName() even with ShowDirsOnly option does not work.
    Let's use the dedicated getExistingDirectory() method instead.
    
    Bug: 11842
    Change-Id: Ie22c4c479005467dbf64d9a90a8f3b82d355d495
    Reviewed-on: https://code.wireshark.org/review/12384
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit ea447aad1fb26e50e790c9370f2e90c8b5d2e3d9)
    Reviewed-on: https://code.wireshark.org/review/12394
    

Actions performed:

    from  fd0a18e   OSTIP: fix typo found by PVS Studio (V519)
    adds  51a80e2   Qt: fix selection of folder in UAT dialog


Summary of changes:
 ui/qt/uat_dialog.cpp |   13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)