Wireshark-commits: [Wireshark-commits] master cda450e: Fix address hashing broken in g4f39c60
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 3 Dec 2015 02:00:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cda450ed591d73aab366569eb748659f194e7168
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cda450e by Evan Huus (eapache@xxxxxxxxx):

    Fix address hashing broken in g4f39c60
    
    We actually have to *use* the return value of the method, which the macro did
    for us.
    
    Change-Id: I240ca7e526a18054fe39c6c4ded902998dc2fef0
    Reviewed-on: https://code.wireshark.org/review/12389
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    Reviewed-by: Jim Young <jim.young.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  de87db6   sctp_chunk_stat_dlg: fix The 'u_data->assoc' variable is assigned values twice successively. found by PVS Studio (V519)
    adds  cda450e   Fix address hashing broken in g4f39c60


Summary of changes:
 asn1/atn-ulcs/packet-atn-ulcs-template.c |    8 ++++----
 epan/conversation.c                      |   24 ++++++++++++------------
 epan/conversation_table.c                |    6 +++---
 epan/dissectors/packet-atn-ulcs.c        |    8 ++++----
 epan/dissectors/packet-dcerpc-netlogon.c |    4 ++--
 epan/dissectors/packet-iax2.c            |    2 +-
 epan/dissectors/packet-netflow.c         |    4 ++--
 ui/gtk/conversation_hastables_dlg.c      |    8 ++++----
 8 files changed, 32 insertions(+), 32 deletions(-)