Wireshark-commits: [Wireshark-commits] master 1d1a893: Add a separate expert info for "not a valid
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 2 Dec 2015 01:43:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1d1a893b61cce8553274ec837b81bb3fe35ea196
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1d1a893 by Guy Harris (guy@xxxxxxxxxxxx):

    Add a separate expert info for "not a valid digit".
    
    That should be used in for errors in the BCD strings where only 0
    through 9 ar valid.
    
    Fix comments to reflect that the two checks for '?' in the output of
    tvb_bcd_dig_to_wmem_packet_str() are doing different checks - one is
    checking for end-of-string padding, the other is checking for anything
    that's not a digit.
    
    Change-Id: I615587b34883ed5bfdc57827451c6e00e213fa5f
    Reviewed-on: https://code.wireshark.org/review/12358
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f27ac81   "#if 0" out unused variables.
    adds  1d1a893   Add a separate expert info for "not a valid digit".


Summary of changes:
 epan/dissectors/packet-gsm_a_dtap.c |   16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)