Wireshark-commits: [Wireshark-commits] master b8f90de: ws80211: Disable shorten-64-to-32.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 1 Dec 2015 01:19:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b8f90de70efa2d271274fbb48df12737f6eddd12
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b8f90de by Gerald Combs (gerald@xxxxxxxxxxxxx):

    ws80211: Disable shorten-64-to-32.
    
    Disable shorten-64-to-32 in ws80211_create_on_demand_interface,
    which calls NLA_PUT_STRING, which passes the output of strlen to an
    int parameter. NLA_PUT_STRING is defined in netlink/attr.h so there's
    not much we can do to fix it directly.
    
    Suppress -Wpragmas before suppressing warnings in gcc so that we can
    use DIAG_OFF with clang-only warnings.
    
    Change-Id: I1180950edd93c056b8fbfbed164e482024aee90a
    Reviewed-on: https://code.wireshark.org/review/12314
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  d487c8c   SpeexDSP: Work around self assignments.
    adds  b8f90de   ws80211: Disable shorten-64-to-32.


Summary of changes:
 caputils/ws80211_utils.c |    3 +++
 wsutil/ws_diag_control.h |   12 +++++++++++-
 2 files changed, 14 insertions(+), 1 deletion(-)