Wireshark · Wireshark-commits: [Wireshark-commits] master-2.0 22cb4c4: Don't allow the "Ethertype" pseudo-protocol's dissection to

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=22cb4c4ff6d0d36b812146ebb1a60c1b2f3beade
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

22cb4c4 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't allow the "Ethertype" pseudo-protocol's dissection to be disabled.
    
    It's not a real protocol, it's a helper dissector for various protocols,
    and it makes no sense to disable it; doing so means that the Ethertype
    field itself isn't disabled, and allowing it to be disabled means that
    you can't do "Disable All", and manually enable Ethernet, IPv4, IPv6,
    and TCP to disable dissection of protocols running atop TCP on Ethernet.
    
    (See
    
        https://ask.wireshark.org/questions/48011/enabled-protocols-negation-of-disabled-proto
    
    for an example of somebody who wants to do exactly that.)
    
    Change-Id: Ibdd6ef53503de548e14cecc3766040c3a0b101d4
    Reviewed-on: https://code.wireshark.org/review/12207
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 677faf2bd4bf233a7d8243b5c5abccf3111cfc5c)
    Reviewed-on: https://code.wireshark.org/review/12208
    

Actions performed:

    from  e3ef813   Wrong field name for signal strength as a percentage.
    adds  22cb4c4   Don't allow the "Ethertype" pseudo-protocol's dissection to be disabled.


Summary of changes:
 epan/dissectors/packet-ethertype.c |    2 ++
 1 file changed, 2 insertions(+)