Wireshark-commits: [Wireshark-commits] master fb11b8a: usbvideo: fix Malformed packet error for SET
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 21 Nov 2015 08:20:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fb11b8a8e2a4fa0c358b1b591cc0b3a9b35c806d
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fb11b8a by Peter Wu (peter@xxxxxxxxxxxxx):

    usbvideo: fix Malformed packet error for SET_CUR
    
    The SET_CUR request does not have an extended pseudo-header, the logic
    likely refers to the extra bytes in the usmon packet header. Remove it
    since the function handles the payload after that header.
    
    Tested with arkmicro_webcam.pcap (from bug 8414) and
    usb-malformed-error.pcapng.gz (from bug 11736).
    
    Bug: 11736
    Change-Id: I61c71bb06c37a626260447f703a5cc4db2a6fc80
    Reviewed-on: https://code.wireshark.org/review/11990
    Reviewed-by: Tim Ansell <mithro@xxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8762e7e   sshdump: add define for default capture bin
    adds  fb11b8a   usbvideo: fix Malformed packet error for SET_CUR


Summary of changes:
 epan/dissectors/packet-usb-video.c |    4 ----
 1 file changed, 4 deletions(-)