Wireshark-commits: [Wireshark-commits] master 227d122: Use the "pcap/pcapng packet data" dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 21 Nov 2015 03:12:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=227d1229e1448b51dce51780e97821f0e9bcdac6
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

227d122 by Guy Harris (guy@xxxxxxxxxxxx):

    Use the "pcap/pcapng packet data" dissector to dissect packet data.
    
    And use the value_string table for LINKTYPE_ values for the link-layer
    header type.
    
    Yes, this means that the "default link-layer header" preference is now a
    LINKTYPE_ value rather than a WTAP_ENCAP_ value.  Both of those were raw
    numbers rather than friendly strings, but at least the most of the
    LINKTYPE_ values are documented on the tcpdump.org Web site, and don't
    change over time, unlike WTAP_ENCAP_ values which can change from
    Wireshark release to release.
    
    Change-Id: Ib752ba2163c6857c9681dc0e07598c96d1e7234f
    Reviewed-on: https://code.wireshark.org/review/12001
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  91f4e3b   Have a separate dissector for pcap/pcapng-format packet data.
    adds  227d122   Use the "pcap/pcapng packet data" dissector to dissect packet data.


Summary of changes:
 epan/dissectors/packet-rpcap.c |   32 +++++++++++++++++++++++++-------
 1 file changed, 25 insertions(+), 7 deletions(-)