Wireshark-commits: [Wireshark-commits] master-2.0 95b7675: Lua: Do not deregister Listener in __gc.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Nov 2015 21:52:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=95b767566b38eab344c9bc620808db5197f97be8
Submitter: Stig Bj?rlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

95b7675 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Lua: Do not deregister Listener in __gc.
    
    Listeners should not be deregistered in __gc because they will go out
    of scope while in use.  Instead free allocated data when deregistering
    the Listener (Listener.remove() and Reload Lua Plugins).
    
    Bug: 11722
    Change-Id: Iadf6506757df06e476ac3cac38c05f1d1d497dc4
    Reviewed-on: https://code.wireshark.org/review/11924
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    (cherry picked from commit 8383cb923b63535b46d52f00f430f784cbbb9014)
    Reviewed-on: https://code.wireshark.org/review/11925
    

Actions performed:

    from  302265e   Qt: Fix some flow graph issues.
    adds  95b7675   Lua: Do not deregister Listener in __gc.


Summary of changes:
 epan/wslua/wslua_listener.c |   15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)