Wireshark-commits: [Wireshark-commits] master 14c35c3: Create C handles for pipes before running du
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Nov 2015 08:08:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=14c35c31d8e77f95abaa601c42566636197641e1
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

14c35c3 by Guy Harris (guy@xxxxxxxxxxxx):

    Create C handles for pipes before running dumpcap.
    
    If the C handles can't be created, there's no point in running dumpcap.
    
    Catch some more possible _open_osfhandle() failures while we're at it.
    
    Change-Id: I2b955378705fc932f8d383804e908e95a957be44
    Ping-Bug: 11702
    Reviewed-on: https://code.wireshark.org/review/11890
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  2dc3b98   Qt: Removed obsolete comments.
    adds  14c35c3   Create C handles for pipes before running dumpcap.


Summary of changes:
 capchild/capture_sync.c |  129 +++++++++++++++++++++++++++++++++--------------
 1 file changed, 90 insertions(+), 39 deletions(-)