Wireshark-commits: [Wireshark-commits] master-2.0 51d1065: epan: Free cf->edt before free cf->epan
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 13 Nov 2015 14:08:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=51d10654cdb2811b316b07e3a37fed68da386ecd
Submitter: Stig Bj?rlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

51d1065 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    epan: Free cf->edt before free cf->epan when redissecting.
    
    This because cf->edt->pi is pointing to data allocated in
    wmem_file_scope and epan_free() will free all data in wmem_file_scope.
    
    In Qt packet_list_clear() we check and use cf->edt, which will give a
    heap-use-after-free error.
    
    Change-Id: I97d532ba976b7bc5fe2995a224ca168edf3da38b
    Reviewed-on: https://code.wireshark.org/review/11803
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    (cherry picked from commit da71ccbf778cca5d9c48e010597570a40fd190c0)
    Reviewed-on: https://code.wireshark.org/review/11806
    

Actions performed:

    from  7c194e7   Qt: Add go to next + previous packet in conversation.
    adds  51d1065   epan: Free cf->edt before free cf->epan when redissecting.


Summary of changes:
 file.c |    2 ++
 1 file changed, 2 insertions(+)