Wireshark-commits: [Wireshark-commits] master-2.0 b10ab40: reassemble: Add key destroy function to
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 6 Nov 2015 04:38:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b10ab40d0dc9763fa2d381567a827e680410bc88
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

b10ab40 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    reassemble: Add key destroy function to g_hash_table
    
    Fixes memleak in reassemble.c
    
    480 bytes in 60 blocks are definitely lost in loss record 3,010 of 3,059
       at 0x4C28C10: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
       by 0xADA3328: g_malloc (in /usr/lib/libglib-2.0.so.0.4600.1)
       by 0xADBA512: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.4600.1)
       by 0x6575C7D: fragment_reassembled (reassemble.c:804)
       by 0x6577785: fragment_add_seq_check_work (reassemble.c:2027)
       by 0x6577880: fragment_add_seq_next (reassemble.c:2068)
       by 0x6E614E6: dissect_sccp_message (packet-sccp.c:2875)
       by 0x6E63641: dissect_sccp (packet-sccp.c:3401)
       by 0x6546CF7: call_dissector_through_handle (packet.c:620)
       by 0x6546EA1: call_dissector_work (packet.c:706)
       by 0x6547A04: dissector_try_uint_new (packet.c:1163)
       by 0x6547A65: dissector_try_uint (packet.c:1189)
    
    Change-Id: I0117b48e1e5d5688c49f264f24387dd6de1d6e08
    Reviewed-on: https://code.wireshark.org/review/11541
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 8fb1f8e55272fca7a3d98356d5d0a58ece7d186e)
    Reviewed-on: https://code.wireshark.org/review/11592
    

Actions performed:

    from  0d0302e   Qt: Check for a sane window geometry.
    adds  b10ab40   reassemble: Add key destroy function to g_hash_table


Summary of changes:
 epan/reassemble.c |   14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)