Wireshark-commits: [Wireshark-commits] master-1.12 e654611: RPC: fix crash when calling NLMv4 SRT s
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 30 Oct 2015 23:37:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e654611ffb00dd1c91eefa6f36654de5fdfd64f2
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

e654611 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    RPC: fix crash when calling NLMv4 SRT statistics
    
    Packet scope is not valid when called from GUI.
    As master-1.12 does not benefit from the code refactring done in master, we
    cannot use the same solution as in g59f4c1c
    Instead allow to leak a bit of memory by allocating in the epan scope.
    
    Bug: 11654
    Change-Id: Ia896299766f7e132b944af48a210fd44d8412282
    Reviewed-on: https://code.wireshark.org/review/11447
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  916dfc5   NLM: fix double memory free when using "Match MSG/RES packets for async NLM" option
    adds  e654611   RPC: fix crash when calling NLMv4 SRT statistics


Summary of changes:
 epan/dissectors/packet-rpc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)