Wireshark-commits: [Wireshark-commits] master 7a381cb: openSAFETY: Remove need for SIII dissector r
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 30 Oct 2015 12:39:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7a381cbcc826e53ad905bb9713dd0e64adf88a3f
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7a381cb by Roland Knall (roland.knall@xxxxxxxxxxxxxxxxx):

    openSAFETY: Remove need for SIII dissector register
    
     Remove the need for the registration of a dedicated SIII dissector,
     as this might interfere with "Decode As" handling, as well as being
     redundant and no longer needed.
    
     The udpdata dissector can handle both and gate to the correct
     sub-dissector if necessary.
    
    Change-Id: I756cd845e7e8d64848d9928ad9ff04d571434835
    Reviewed-on: https://code.wireshark.org/review/11421
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  a4b1cde   couchbase: implement comand 0x48 to get vbucket seqnos
    adds  7a381cb   openSAFETY: Remove need for SIII dissector register


Summary of changes:
 epan/dissectors/packet-opensafety.c |   25 +++++++++----------------
 1 file changed, 9 insertions(+), 16 deletions(-)