Wireshark-commits: [Wireshark-commits] master-1.12 3690d13: EtherCAT: wrong display name
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 29 Oct 2015 14:34:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3690d133625b661eb9c64ec6b988e25be62630b1
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

3690d13 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    EtherCAT: wrong display name
    
    Wireshark is showing 2 consecutive bytes named "SubIdx" in a SDO info request (OpCode = 0x5) and response (OpCode = 0x6). But the second byte should be the "ValueInfo" instead in both request and response.
    
    Issue reported by ThoKu
    
    Bug:11652
    Change-Id: I7f6395208d38e714071de5dbb40e3ddb9829f210
    Reviewed-on: https://code.wireshark.org/review/11397
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 6c9ddbda65408ed15af69d74bfaa881e308f63b2)
    Reviewed-on: https://code.wireshark.org/review/11401
    

Actions performed:

    from  b3f977c   pcp: fix reporting of error status in info column
    adds  3690d13   EtherCAT: wrong display name


Summary of changes:
 plugins/ethercat/packet-ecatmb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)