Wireshark-commits: [Wireshark-commits] master d1f0e72: frame_data: Reset subnum if visited is reset
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 28 Oct 2015 13:55:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d1f0e7273401e1470b8ed919961e6989eab1f986
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d1f0e72 by Roland Knall (roland.knall@xxxxxxxxxxxxxxxxx):

    frame_data: Reset subnum if visited is resetted
    
     subnum get's resetted when the file is reloaded. But subnum
     does not get resetted, if for instance a preference has been
     set directly via (Protocol Name)->Protocol Preferences-> ...
     in the Protocol list. But flags.visited get's resetted.
    
     This leads to the scenario, where reloading a trace starts subnum
     with 0 and applying a preference starts subnum with the highest
     value it had before.
    
     This patch ensures, that all methods for reloading the frame
     lead to the same init value
    
    Change-Id: I167d1e03f7e2e6c60492f501ee5cb9555ac12ac9
    Reviewed-on: https://code.wireshark.org/review/11341
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  9b3bda9   epan_init(): make 'status' volatile (to avoid might-be-clobbered warnings).
    adds  d1f0e72   frame_data: Reset subnum if visited is resetted


Summary of changes:
 epan/frame_data.c |    1 +
 1 file changed, 1 insertion(+)