Wireshark-commits: [Wireshark-commits] master-2.0 ada3972: Improve dissection of HSRPv1 packets usi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 28 Oct 2015 11:37:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ada39722b92d0807c4102836a644472568da89ec
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

ada3972 by Dhiru Kholia (kholia@xxxxxx):

    Improve dissection of HSRPv1 packets using MD5 authentication
    
    HSRP (Version: 0) can use MD5 Authentication TLV sequence for
    authentication, and such packets are now dissected properly.
    
    Sample HSRP (Version: 0), and HSRPv2 .pcap files can be found at,
    https://github.com/kholia/my-pcaps
    
    Change-Id: Ib84d344c6977065b1948231503d13c675de34ea4
    Reviewed-on: https://code.wireshark.org/review/11285
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 25d0f736f37a4f3a2a53f19c8e89e20359e0aba9)
    Reviewed-on: https://code.wireshark.org/review/11342
    

Actions performed:

    from  a68181b   opcua: display string representation of AttributeId and DeadbandType
    adds  ada3972   Improve dissection of HSRPv1 packets using MD5 authentication


Summary of changes:
 epan/dissectors/packet-hsrp.c |  187 ++++++++++++++++++++++++-----------------
 1 file changed, 109 insertions(+), 78 deletions(-)