Wireshark-commits: [Wireshark-commits] master-2.0 4d9c42f: Add jitter logic to RtpAudioStream.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 27 Oct 2015 18:57:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4d9c42f753add5a9e54898eaeb52c57e76d7ad1f
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

4d9c42f by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Add jitter logic to RtpAudioStream.
    
    Copy the jitter logic from rtp_player.c to rtp_audio_stream.cpp. This
    still isn't correct but the RTP player should now be complete enough to
    start looking at the bug list at the top of rtp_player_dialog.cpp.
    
    Disable timing and jitter controls while we're playing while we're here.
    Fixes bug 11635.
    
    Bug: 11635
    Change-Id: Ie583ade522702cbe1bbcea4475a535caa1d74fa2
    Reviewed-on: https://code.wireshark.org/review/11295
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 2ccb9d2d957a6c118c00a193d0fbe19712153208)
    Reviewed-on: https://code.wireshark.org/review/11320
    

Actions performed:

    from  7c35e1f   qt: add missing initializers (CID 1325722)
    adds  4d9c42f   Add jitter logic to RtpAudioStream.


Summary of changes:
 ui/qt/rtp_audio_stream.cpp  |  247 +++++++++++++++++++++++++++++++++++++------
 ui/qt/rtp_audio_stream.h    |   53 +++++++++-
 ui/qt/rtp_player_dialog.cpp |   85 ++++++++++++++-
 ui/qt/rtp_player_dialog.h   |    5 +-
 ui/qt/rtp_player_dialog.ui  |    7 +-
 ui/rtp_stream.h             |    2 +-
 6 files changed, 354 insertions(+), 45 deletions(-)