Wireshark-commits: [Wireshark-commits] master-2.0 fe8ee7d: Convert SIP statistics to the stat tap A
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 27 Oct 2015 15:21:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fe8ee7ddfefe166707b2e90531c28861d3874abe
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

fe8ee7d by Gerald Combs (gerald@xxxxxxxx):

    Convert SIP statistics to the stat tap API.
    
    It looks like this one fell through the cracks because it dynamically
    registered itself via register_tap_listener_gtksipstat and wasn't listed
    in the "/Telephony/" path in main_menubar.c.
    
    Ping-Bug: 11638
    Change-Id: I4c82b36d204207c81e82a19efce98b6a091351ca
    Reviewed-on: https://code.wireshark.org/review/11293
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 08e44b8b43ad4234a93b8feaa8e8174373188080)
    Reviewed-on: https://code.wireshark.org/review/11311
    

Actions performed:

    from  49e2509   Replace all "dissector filter" registrations with "dissector color filter" registration.
    adds  fe8ee7d   Convert SIP statistics to the stat tap API.


Summary of changes:
 epan/dissectors/packet-sip.c |  318 ++++++++++++++++++-
 epan/dissectors/packet-sip.h |   22 +-
 ui/gtk/CMakeLists.txt        |    1 -
 ui/gtk/Makefile.common       |    1 -
 ui/gtk/sip_stat.c            |  705 ------------------------------------------
 ui/qt/main_window.cpp        |    1 +
 ui/qt/main_window.ui         |    1 -
 7 files changed, 328 insertions(+), 721 deletions(-)
 delete mode 100644 ui/gtk/sip_stat.c