Wireshark-commits: [Wireshark-commits] master-2.0 49e2509: Replace all "dissector filter" registrat
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 27 Oct 2015 11:42:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=49e25093fc887027bb798496bf55946c8bc7de29
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

49e2509 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Replace all "dissector filter" registrations with "dissector color filter" registration.
    
    In the GTK, there was "colorize" (via context menu using color_dissector_filter.{c,h}) or "not colorize" (via main menu using dissector_filters.{c,h}).  In Qt, you have the option to colorize (via context menu using color_dissector_filter.{c,h}) or not colorize (via main menu using color_dissector_filter.{c,h}).
    
    Combine all into "colorize" and convert GTK to use color_dissector_filter.{c,h} in the "not colorize" main menu like Qt.
    
    Change-Id: Ib3ca1c822f5f66ab5b812632d808f7905b328483
    Reviewed-on: https://code.wireshark.org/review/11263
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 616dbd78d6afc4f8825ce159de23b19752859605)
    Reviewed-on: https://code.wireshark.org/review/11304
    

Actions performed:

    from  393ac5a   Only store frame number and not a pointer to frame_data structure in seq_analysis_item_t
    adds  49e2509   Replace all "dissector filter" registrations with "dissector color filter" registration.


Summary of changes:
 debian/libwireshark0.symbols           |    2 --
 epan/CMakeLists.txt                    |    1 -
 epan/Makefile.common                   |    2 --
 epan/dissector_filters.c               |   57 -----------------------------
 epan/dissector_filters.h               |   61 --------------------------------
 epan/dissectors/packet-enip.c          |   10 +++---
 plugins/profinet/packet-dcerpc-pn-io.c |   10 +++---
 ui/gtk/main_menubar.c                  |   25 ++++++-------
 8 files changed, 23 insertions(+), 145 deletions(-)
 delete mode 100644 epan/dissector_filters.c
 delete mode 100644 epan/dissector_filters.h