Wireshark-commits: [Wireshark-commits] master-2.0 393ac5a: Only store frame number and not a pointe
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 27 Oct 2015 09:38:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=393ac5a8fcea8c0d5c9903e6dd9f68ad87fb8464
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

393ac5a by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Only store frame number and not a pointer to frame_data structure in seq_analysis_item_t
    
    Qt GUI allows to keep windows open after closing the capture file. Let's not access to freed memory.
    
    Bug: 11573
    Change-Id: I9e70d818a4b228af319961ec512b6b9725792477
    Reviewed-on: https://code.wireshark.org/review/11270
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 1ea43c26e68d92838a7d91dce4fe9686b09f12c7)
    Conflicts:
    	ui/gtk/lbm_uimflow_dlg.c
    	ui/qt/lbm_uimflow_dialog.cpp
    	ui/voip_calls.c
    Reviewed-on: https://code.wireshark.org/review/11303
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  b298df0   nfs: Add FF_FLAGS_NO_IO_THRU_MDS for layout flags
    adds  393ac5a   Only store frame number and not a pointer to frame_data structure in seq_analysis_item_t


Summary of changes:
 ui/gtk/graph_analysis.c      |    6 +++---
 ui/gtk/graph_analysis.h      |    2 +-
 ui/gtk/lbm_uimflow_dlg.c     |    4 ++--
 ui/gtk/rtp_player.c          |    2 +-
 ui/gtk/voip_calls_dlg.c      |    2 +-
 ui/qt/lbm_uimflow_dialog.cpp |    6 +++---
 ui/qt/sequence_diagram.cpp   |    2 +-
 ui/qt/sequence_dialog.cpp    |    2 +-
 ui/qt/voip_calls_dialog.cpp  |    4 ++--
 ui/tap-sequence-analysis.c   |   21 ++++++++++++---------
 ui/tap-sequence-analysis.h   |    2 +-
 ui/voip_calls.c              |   34 +++++++++++++++++-----------------
 12 files changed, 45 insertions(+), 42 deletions(-)