Wireshark-commits: [Wireshark-commits] master-2.0 d570544: Show the Experimental-Result-Code if we
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 27 Oct 2015 07:31:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d570544b972ddd108223ecec1ce2877718c7fa92
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

d570544 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Show the Experimental-Result-Code if we don't know have a subdissector for that
    vendor ID.
    
    Otherwise the value is simply not shown to the user.
    
    Adding support for a vendor ID's Experimental Result Codes isn't as easy as
    modifying the XML so don't add an expert info about it.
    
    Change-Id: I65f2cb13853cc7141fb242fa03c6e474a6c02cb9
    Reviewed-on: https://code.wireshark.org/review/11294
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 49894f023339463a11e97b482ff5780d1ee14efd)
    Reviewed-on: https://code.wireshark.org/review/11296
    

Actions performed:

    from  8f36767   extcap: add missing types in doc.
    adds  d570544   Show the Experimental-Result-Code if we don't know have a subdissector for that vendor ID.


Summary of changes:
 epan/dissectors/packet-diameter.c |   31 ++++++++++++++++++++++++++-----
 1 file changed, 26 insertions(+), 5 deletions(-)