Wireshark-commits: [Wireshark-commits] master-2.0 258a41e: There's no need for all these variables
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 26 Oct 2015 08:35:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=258a41e5b0ca5865cd4aba52c90a85a8c00d9149
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

258a41e by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    There's no need for all these variables to be volatile.
    
    I suppose there must have been TRYs and CATCHes in here years ago. And/or
    there was just too much cutting-and-pasting going on here.
    
    Also reindent some col_ calls: they weren't moved left when check_col() was
    taken out.
    
    Change-Id: I0b01e008395be5b638a0470645d247dc706ca93f
    Reviewed-on: https://code.wireshark.org/review/11254
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit cc77d6c66f0c0c32bda005bacbac686a158b95d0)
    Reviewed-on: https://code.wireshark.org/review/11275
    

Actions performed:

    from  b67599c   There's no need to register 32 hf's which are identical except for the name: one will do.
    adds  258a41e   There's no need for all these variables to be volatile.


Summary of changes:
 epan/dissectors/packet-ieee8021ah.c |   32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)