Wireshark-commits: [Wireshark-commits] master-1.12 3b42eab: 802.1ah: call subdissectors even when w
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 25 Oct 2015 02:25:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3b42eabd77a132ff7503af3b0eb7daed82ca700c
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

3b42eab by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    802.1ah: call subdissectors even when we have no tree.
    
    Otherwise none of the subdissectors are called on the first pass which means
    none of their analysis (which is generally done on the first pass) is going to
    work.
    
    Bug: 11629
    Change-Id: I6fe8d0692e5cf6f5b5fa099d31a91d01cc5c7c68
    Reviewed-on: https://code.wireshark.org/review/11226
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit ae130f114cd61443c8c93e1c9280e027726a0235)
    Conflicts:
    	epan/dissectors/packet-ieee8021ah.c
    Reviewed-on: https://code.wireshark.org/review/11255
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  fcdb061   T38: fix a dereference of NULL pointer
    adds  3b42eab   802.1ah: call subdissectors even when we have no tree.


Summary of changes:
 epan/dissectors/packet-ieee8021ah.c |   17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)