Wireshark-commits: [Wireshark-commits] master-2.0 cc8d1eb: [aeron] a new-style dissector should ret
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 24 Oct 2015 23:59:57 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cc8d1ebd4d7d651170f2a4c421218bf5ec1ddd1a
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

cc8d1eb by Martin Kaiser (wireshark@xxxxxxxxx):

    [aeron] a new-style dissector should return 0 (not -1) to reject a packet
    
    we shouldn't throw an exception before we know that the packet
    contains our protocol
    
    Change-Id: Ic58cb985775766a18e9086fe52096e3290674515
    Reviewed-on: https://code.wireshark.org/review/11248
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 3ea14493e7091cbfb40e0cb6bf9f91e78d57d9d4)
    Reviewed-on: https://code.wireshark.org/review/11252
    

Actions performed:

    from  c515bd3   NTP timestamps can't be relative.
    adds  cc8d1eb   [aeron] a new-style dissector should return 0 (not -1) to reject a packet


Summary of changes:
 epan/dissectors/packet-aeron.c |   15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)