Wireshark-commits: [Wireshark-commits] master 02d56ff: TDS: Replace use of val_to_str() with VALS()
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 24 Oct 2015 12:57:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=02d56ffa9c540dde3c3a9d1a77bd90f5a3b98962
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

02d56ff by Nathan Cole (nath@xxxxxxxxxxxxxxxxxxxxxx):

    TDS: Replace use of val_to_str() with VALS()
    
    Multiple uses of val_to_str replaced, allowing proto_tree_add_item and
    proto_item_append_text to be replaced with just proto_tree_add_item.
    
    While changing this aspect in dissect_tds7_prelogin_packet, I strengthened
    the add_item calls so that integer fields could not be passed with invalid
    lengths.
    
    Bug: 11631
    Change-Id: I556c4d965fd4ee5dffa36b538695d46e422062de
    Reviewed-on: https://code.wireshark.org/review/11239
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  2cec957   T38: fix a dereference of NULL pointer
    adds  02d56ff   TDS: Replace use of val_to_str() with VALS()


Summary of changes:
 epan/dissectors/packet-tds.c |   33 +++++++++++++--------------------
 1 file changed, 13 insertions(+), 20 deletions(-)