Wireshark · Wireshark-commits: [Wireshark-commits] master 99406ba: Add to DIS dissector many new PDU types, fixing issues, and rich

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=99406bafe19ae6acf6867d8b6737f6aad0a1a8c8
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

99406ba by Oren Koler (clicker78@xxxxxxxxx):

    Add to DIS dissector many new PDU types, fixing issues, and richer information.
    
    This is a massive changeset, developed by Oren Koler from IDF BattleLab, and is being integrated by me.
    IDF BattleLab enhanced this dissector for its own popular PDUs, and was tested successfully by its own DIS scenarios.
    
    We also fixed those issues:
    * Only zero or one timestamp in DIS packet header (division of integer by integer)
    * Bad datum values padding.
    
    IDF BattleLab outputs the result of Oren Koler work to the community.
    
    Sadly, because of information security, we couldn't share recorded captures with the community.
    However, we brought basic PDU record outside from IDF BattleLab.
    
    Change-Id: Iec425569da3842f7054a97be5f371cbe893ff482
    Reviewed-on: https://code.wireshark.org/review/10710
    Reviewed-by: Tal Hadad <tal_hd@xxxxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  fd5aa7d   LTE RLC graph: Only enable graph buttons for directions with data
    adds  99406ba   Add to DIS dissector many new PDU types, fixing issues, and richer information.


Summary of changes:
 epan/dissectors/packet-dis.c | 1982 ++++++++++++++++++++++++++++++++++++------
 1 file changed, 1725 insertions(+), 257 deletions(-)