Wireshark-commits: [Wireshark-commits] master 4a5977b: X11 generator: avoid extraneous parens in co
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 20 Oct 2015 23:44:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a5977b587deeca40d9bbdd55a0ebf3f33059372
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4a5977b by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    X11 generator: avoid extraneous parens in conditionals.
    
    This is to avoid complaints from clang of the form:
    
    wireshark/epan/dissectors/x11-extension-implementation.h:17021:18: error:
    equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
            if ((f_class_id == 0)) {
                 ~~~~~~~~~~~^~~~
    
    Change-Id: I91d629ad47677b71909d7da517c4a6198c276186
    Reviewed-on: https://code.wireshark.org/review/11186
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  9768a3e   LTE dialogs: tidy up some loose ends
    adds  4a5977b   X11 generator: avoid extraneous parens in conditionals.


Summary of changes:
 epan/dissectors/x11-extension-implementation.h |  364 ++++++++++++------------
 epan/dissectors/x11-glx-render-enum.h          |    2 +-
 tools/process-x11-xcb.pl                       |   19 +-
 3 files changed, 199 insertions(+), 186 deletions(-)