Wireshark-commits: [Wireshark-commits] master-2.0 0409034: x11 generator: Don't crash when a switch
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 19 Oct 2015 18:57:22 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=04090340fe8e7539452494e8b2c20d117e85c914
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

0409034 by Peter Harris (pharris@xxxxxxxxxxxx):

    x11 generator: Don't crash when a switch is in a struct
    
    The size calculation for the struct will be wrong (too small) which looks
    strange in the GUI when the children elements extend past the region
    marked by their parent. But it doesn't seem to cause any actual problems,
    there is only one request affected by this, and correct size calculation
    (by recursing the switch) would take a fair amount of work.
    
    Change-Id: I1847f736153daf59b8dbf3299005a772ffe9673a
    Reviewed-on: https://code.wireshark.org/review/11107
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    (cherry picked from commit 4ff02903a65dc9dcc8bd97613e46a6736cda46a1)
    Reviewed-on: https://code.wireshark.org/review/11157
    

Actions performed:

    from  d3a59df   x11 generator: Fix struct size with array
    adds  0409034   x11 generator: Don't crash when a switch is in a struct


Summary of changes:
 tools/process-x11-xcb.pl |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)